Skip to content

Fix CMake package discovery and streamline library setup. #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: release/6.3.0
Choose a base branch
from
Open

Fix CMake package discovery and streamline library setup. #196

wants to merge 6 commits into from

Conversation

Priyanka328
Copy link

  • Resolved CMake package discovery issue for external projects.
  • Refactored library setup for improved modularity and organization.
  • Enhanced installation process with proper targets.
  • Added support for C++17 features in the library.
  • Created a CMake export for the library interface to facilitate external use.

@Priyanka328
Fix CMake package discovery and streamline library setup.
d8ce07a 
- Resolved CMake package discovery issue for external projects.
- Refactored library setup for improved modularity and organization.
- Enhanced installation process with proper targets.
- Added support for C++17 features in the library.
- Created a CMake export for the library interface to facilitate external use.
waywardmonkeys
waywardmonkeys reviewed Mar 5, 2024
View reviewed changes
Copy link

@waywardmonkeys waywardmonkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been on my list to do so that I could finish up my vcpkg port…

Dekker1
Dekker1 suggested changes Mar 27, 2024
View reviewed changes
@zayenz
Copy link
Member

zayenz commented Mar 28, 2024

Thanks for the help in reviewing @waywardmonkeys and @Dekker1.

Running the CI and will be testing locally as well.

@Priyanka328
Copy link
Author

Hi everyone, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@waywardmonkeys waywardmonkeys waywardmonkeys left review comments

@Dekker1 Dekker1 Dekker1 requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Priyanka328 @zayenz @waywardmonkeys @Dekker1